This patch is proposed for two reasons.
Firstly, with reference to
https://lore.kernel.org/linux-trace-devel/Yl9WBztqKGD0PpmJ@ArchDesktop/
when the CMake does not detect FreeSans, it should cease generating the
Makefile since kernelshark requires FreeSans to output its graph
properly.
Secondly, when the make instructions on the README are followed, even
when FreeSans is not detected, `make` continues to compile and `make
install` (or `install_gui`) would install without indicating an error.
This gives the impression of a successful install, but `kernelshark`
will be missing.
Therefore, making CMake quit with error when FreeSans is not installed
solves these two issues.
Signed-off-by: Solomon Tan <wjsota@xxxxxxxxx>
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e6a76d8..5473bfa 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -69,7 +69,7 @@ if (TT_FONT_FILE)
else (TT_FONT_FILE)
- message(WARNING "\nCould not find font ${KS_FONT}!\n")
+ message(FATAL_ERROR "\nCould not find font ${KS_FONT}!\n")
endif (TT_FONT_FILE)
--
2.36.0
|