On Mon, Apr 4, 2022 at 11:40 AM Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote: > > On Mon, Apr 4, 2022 at 11:32 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > On Mon, 4 Apr 2022 11:27:58 -0400 > > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > > Sure, if you compile it yourself, it may not be supported (which is what I > > > hit), but at least we guarantee that it will be supported across machines > > > using the same distro if we make it compile time dependent. > > > > Not to mention, I have use cases where trace-cmd needs to be installed in > > an environment with no dynamic libraries (nor using dlopen). Everything > > will be built statically. trace-cmd report will not be used, but trace-cmd > > agent will be. > > > > Remember, trace-cmd is to be embedded friendly. > > Agreed, so should I send a patch next to do memfd unless > not-compressed? Is there an easy way to do not-compressed? Sorry I meant "is there an easy way to detect, in this code path, that we are running in not compressed mode" ? I guess I could just check the argv but I haven't looked closely yet. Thanks, - Joel
|