Re: Comments on new user events ABI
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: Comments on new user events ABI
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Tue, 29 Mar 2022 15:45:32 -0400
- Cc: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, bpf <bpf@xxxxxxxxxxxxxxx>, Network Development <netdev@xxxxxxxxxxxxxxx>, Beau Belgrave <beaub@xxxxxxxxxxxxxxxxxxx>, Beau Belgrave <beaub@xxxxxxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, linux-trace-devel <linux-trace-devel@xxxxxxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>
- In-reply-to: <CAADnVQK=GCuhTHz=iwv0r7Y37gYvt_UBzkfFJmNT+uR0z+7Myw@mail.gmail.com>
- References: <2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com> <20220329002935.2869-1-beaub@linux.microsoft.com> <1014535694.197402.1648570634323.JavaMail.zimbra@efficios.com> <CAADnVQK=GCuhTHz=iwv0r7Y37gYvt_UBzkfFJmNT+uR0z+7Myw@mail.gmail.com>
On Tue, 29 Mar 2022 09:25:52 -0700
Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote:
> Thanks for flagging.
>
> Whoever added this user_bpf* stuff please remove it immediately.
> It was never reviewed by bpf maintainers.
Heh, now you know how the x86 maintainers feel ;-)
>
> It's a hard Nack to add a bpf interface to user_events.
Agreed, I'm thinking of marking the entire thing as broken such that it can
be worked on a bit more without a total revert (but still remove the BPF
portion on your request).
Beau, I agree with Mathieu, I don't think it's a good idea to expose the
"ftrace/perf/etc" users. The only thing that the application needs is a bit
to say "call the write now". And let the work be done within the kernel.
I think a single bit may be better, that way you can have many more events
on a page, and since they do not get modified often, it will be in hot
cache and fast.
-- Steve
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]