On Tue, 22 Feb 2022 09:46:34 -0800 Beau Belgrave <beaub@xxxxxxxxxxxxxxxxxxx> wrote: > Yes, I was thinking along the same lines. I saw how things were split > between private / public in the headers and wasn't sure how to > accomplish this. > > What you have above seems like a great way to accomplish this without exposing > too much out. Just in case we ever want to extend the user view, I wonder if we should also expose the size as the next argument (or the first). struct tracefs_user_event { unsigned int size; char *enable; }; and set size to sizeof(struct tracefs_user_event). Then if we add another field, we can differentiate it from new additions, without breaking forward or backward API. -- Steve