Re: [PATCH] trace-cmd reset: Clear all dynamic events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 12, 2022 at 4:56 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Fri, 14 Jan 2022 12:57:48 +0200
> "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
>
> > +     /* Clear event probes first, as they may be attached to other dynamic event */
> > +     tracefs_dynevent_destroy_all(TRACEFS_DYNEVENT_EPROBE, true);
> > +     tracefs_dynevent_destroy_all(TRACEFS_DYNEVENT_KPROBE |
> > +                                  TRACEFS_DYNEVENT_KRETPROBE |
> > +                                  TRACEFS_DYNEVENT_UPROBE |
> > +                                  TRACEFS_DYNEVENT_URETPROBE |
> > +                                  TRACEFS_DYNEVENT_SYNTH,
> > +                                  true);
> >  }
>
> I accepted this patch, but really, tracefs needs something to define:
>
>         TRACEFS_DYNEVENT_ALL
>
> as callers should not have to call out each type of dynamic event.
> Especially when we are about to add new dynamic events, causing this to
> break again.
>
> Want to add that?
>

Sure, I'll send a patch with that.
Thanks!


> Thanks Tzvetomir,
>
> -- Steve



-- 
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux