On Tue, 18 Jan 2022 17:40:19 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > I guess you use 'goto err;' everywhere, because you want to stress that returning NULL is essentially exiting with > > error. However, so far we used just 'return NULL' everywhere and I would prefer to keep the code consistent. > > Maybe in a separate patch we can replace all ''return NULL;' lines with a macro that can have some self-explanatory name? > > Yeah, I was trying to match the existing code, as I'm new to this. ;-) Oh, if you haven't noticed. I created a tracefs_instance_get_affinity() API as well ;-) https://patchwork.kernel.org/project/linux-trace-devel/patch/20220118030005.1603821-2-rostedt@xxxxxxxxxxx/ -- Steve
|