On Sat, Jan 15, 2022 at 6:00 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
[...]
> > +
> > +static int read_headers_v7(struct tracecmd_input *handle)
>
> I really like how these changes are coming. This makes the reading of the
> tracing file much more manageable. Great job Tzvetomir!
>
> Only comment to this patch is, as I've said in other patches, I don't think
> we need to call this _v7, just "read_headers()" would suffice.
The read header logic is very different, we should name the old
function somehow. Now we have
read_headers_v6() / read_headers_v7()
I can rename them to
read_headers_old() / read_headers()
or
read_headers_nosections() / read_headers_sections()
>
> -- Steve
[...]
--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
|