Hi Tzvetomir and Yordan,
I'm not sure my sign-off is necessary, but if Yordan wants it, you have
it :-)
Cheers,
-Michal
On Thu, Jan 13 2022, Tzvetomir Stoyanov (VMware) wrote:
> Using cmake imported targets instead of package variables is
> recommended way to define package dependencies.
>
> The GLUT_LIBRARY cmake variable was renamed in cmake 3.22.1, which
> breaks the Kernel Shark build with the latest cmake.
>
> Reported-by: Michal Sojka <michal.sojka@xxxxxxx>
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx>
Signed-off-by: Michal Sojka <michal.sojka@xxxxxxx>
> ---
> src/CMakeLists.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
> index babb9c1..9e0b4ae 100644
> --- a/src/CMakeLists.txt
> +++ b/src/CMakeLists.txt
> @@ -59,8 +59,8 @@ if (OPENGL_FOUND)
> KsPlugins.cpp)
>
> target_link_libraries(kshark-plot kshark
> - ${GLUT_LIBRARY}
> - ${OPENGL_LIBRARIES})
> + GLUT::GLUT
> + OpenGL::GLU)
>
> set_target_properties(kshark-plot PROPERTIES SUFFIX ".so.${KS_VERSION_STRING}")
> install(TARGETS kshark-plot
> --
> 2.34.1
|