On 14.01.22 г. 12:12 ч., Tzvetomir Stoyanov wrote:
On Fri, Jan 14, 2022 at 10:17 AM Yordan Karadzhov (VMware) <y.karadz@xxxxxxxxx> wrote:A new API is proposed, to get tep event descriptor for given synthetic event: tracefs_synth_get_event () The API implementation gets derived from the implementation of the existing API tracefs_dynevent_get_event(). It can detect any newly created or removed synthetic events. Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@xxxxxxxxx> --- Documentation/libtracefs-synth2.txt | 13 +++++++++++-- include/tracefs-local.h | 2 ++ include/tracefs.h | 2 ++ src/tracefs-dynevents.c | 17 +---------------- src/tracefs-events.c | 21 +++++++++++++++++++++ src/tracefs-hist.c | 18 ++++++++++++++++++ 6 files changed, 55 insertions(+), 18 deletions(-) diff --git a/Documentation/libtracefs-synth2.txt b/Documentation/libtracefs-synth2.txt index 8056ab8..444318c 100644 --- a/Documentation/libtracefs-synth2.txt +++ b/Documentation/libtracefs-synth2.txt @@ -6,7 +6,8 @@ NAME tracefs_synth_create, tracefs_synth_destroy, tracefs_synth_echo_cmd, tracefs_synth_complete, tracefs_synth_get_start_hist, tracefs_synth_trace, tracefs_synth_snapshot, tracefs_synth_get_name, tracefs_synth_raw_fmt, tracefs_synth_show_event, -tracefs_synth_show_start_hist, tracefs_synth_show_end_hist - Creation of synthetic events +tracefs_synth_show_start_hist, tracefs_synth_show_end_hist, tracefs_synth_get_eventThe new API should be added also in Documentation/libtracefs.txt, the main man page with all APIs. Forgot to mention that in the previous review.
Hmm, I see absolutely no tracefs_synth_*() APIs in Documentation/libtracefs.txt. Maybe this can be fixed in a separate patch. thanks, Yordan
[ ... ]
|