> On Jan 13, 2022, at 12:24 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Tue, 11 Jan 2022 13:59:27 -0500 > Chuck Lever <chuck.lever@xxxxxxxxxx> wrote: > >> Enable a struct sockaddr to be stored in a trace record as a >> dynamically-sized field. The common cases are AF_INET and AF_INET6 >> which are different sizes, and are vastly smaller than a struct >> sockaddr_storage. >> >> These are safer because, when used properly, the size of the >> sockaddr destination field in each trace record is now guaranteed >> to be the same as the source address that is being copied into it. >> >> Link: https://lore.kernel.org/all/164182978641.8391.8277203495236105391.stgit@xxxxxxxxxxxxxxxxxxxxxxx/ >> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> >> --- > > This looks fine to me. The only comment I have is that the subject should > be "tracing: ..." not "trace: ..." as "tracing" is what we use for the > tracing subsystem. Will fix. > I'll test this out if I get time. No hurry on my part. -- Chuck Lever
|