> >-----Original Message----- >From: Yordan Karadzhov <y.karadz@xxxxxxxxx> >Sent: Monday, January 10, 2022 9:10 PM >To: Chen, Hongzhan <hongzhan.chen@xxxxxxxxx>; linux-trace-devel@xxxxxxxxxxxxxxx >Subject: Re: [PATCH V4 2/3] kernel-shark: Move common APIs and definitions out to avoid duplication > >Hi Hongzhan, > >This patch breaks the build on my machine. >More comments below. > >On 10.01.22 ?. 6:25 ?., Hongzhan Chen wrote: >> To avoid code duplication, move some common APIs and definitions >> out from plugin SchedEvent to share with other plugins. >> >> Signed-off-by: Hongzhan Chen <hongzhan.chen@xxxxxxxxx> >> >> diff --git a/src/KsPlugins.cpp b/src/KsPlugins.cpp >> index ad9f478..a288018 100644 >> --- a/src/KsPlugins.cpp >> +++ b/src/KsPlugins.cpp > >In this file we have a missing include. We need >#include <limits> > I have not reproduced the issue on my machine. After google limits include thing, the issue you met I guess is similar to https://discourse.vtk.org/t/compilation-error-include-limits-required-in-several-files/6496 which should be related to GCC version 11+ which remove some include dependences as described in http://gcc.gnu.org/gcc-11/porting_to.htmlbut and we should include explicitly limits when compiled with GCC 11 but I am just using gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04). After I upgrade to GCC 11.2 and I can reproduce limits issue now. I will modify it .Sorry for the inconvenience. Regards Hongzhan Chen
|