On 07.01.22 13:24, Yordan Karadzhov wrote:
>
>
> On 7.01.22 г. 13:57 ч., Jan Kiszka wrote:
>> On 07.01.22 12:10, Yordan Karadzhov wrote:
>>> Hi Hongzhan and Jan,
>>>
>>> Have you decided something about the way this plugin will be maintained?
>>>
>>
>> No decision yet. I'm still waiting for an answer on
>> https://lore.kernel.org/linux-trace-devel/9ac9a1af-6829-425a-7943-755decf7c273@xxxxxxxxx/
>>
>> regarding maintenance of different tracepoint revisions. That would be
>> implicit when keeping the plugin in lock-step with the tracepoints in
>> the same repo.
>
> OK.
>
>>
>> But then the question would be how mature the interface lifecycle
>> management of kernelshark and libs is /wrt external plugins. Those may
>> need to account for potential changes in those APIs over the time, right?
>>
>
> The APIs are not supposed to change. I cannot give you an absolute
> guarantee, but we will do our best to keep the interface stable. Anyway,
> even if we have to do some minor changes in the future, it will be our
> responsibility to communicate this and help with fixing all external
> plugins we are aware of.
>
> The whole idea behind the design of this interface is to be friendly for
> external plugins.
>
OK, that sound motivating to look into the external path. I suppose only
the auto-loading topic should be improved then.
>> We will likely pick the path that is least inconvenient.
>>
>> [...]
>>
>>>> + eventFieldIntervalPlot(argvCpp,
>>>> + plugin_ctx->cs_data, checkFieldCS,
>>>> + plugin_ctx->cs_data, checkEntryPid,
>>>> + makeLatencyBox<XenomaiSwitchBox>,
>>>> + {0, 0, 255}, // Blue
>>>
>>> Perhaps you can use 'cobalt blue' instead of just blue ;-)
>>>
>>
>> Makes sense ;)
>>
>> Seriously: Is there some caption somewhere that explains the meaning of
>> colors? If so, how to hook into that?
>
> So far we do not have special convention for the meaning of the colors.
>
But also no textual description of their semantics yet, right? Where
could this be added best to the UI?
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
|