Re: [PATCH] perf build: Lower the priority of tools/lib includes
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] perf build: Lower the priority of tools/lib includes
- From: Ian Rogers <irogers@xxxxxxxxxx>
- Date: Thu, 6 Jan 2022 12:24:18 -0800
- Cc: Jiri Slaby <jirislaby@xxxxxxxxxx>, linux-trace-devel@xxxxxxxxxxxxxxx, Steven Rostedt <rostedt@xxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, linux-perf-users@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx>, torvalds@xxxxxxxxxxxxxxxxxxxx, eranian@xxxxxxxxxx
- In-reply-to: <YddDcqxtDrPDSAVi@kernel.org>
- References: <20220106072627.476524-1-irogers@google.com> <YddC+lzAO1Urj0TF@kernel.org> <YddDcqxtDrPDSAVi@kernel.org>
On Thu, Jan 6, 2022 at 11:31 AM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> Em Thu, Jan 06, 2022 at 04:28:58PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Jan 05, 2022 at 11:26:27PM -0800, Ian Rogers escreveu:
> > > tools/lib has a 1.1.0 copy of libtraceevent. If a newer system
> > > version is installed then its headers will go in /usr/include. As -I has
> > > priority over system headers the 1.1.0 version gets used in preference
> > > to the system one, which isn't what is wanted. To make the behavior
> > > match expectations use -idirafter so that any system headers have priority
> > > over the tools/lib version.
> > >
> > > Fixes: 08efcb4a638d ("libtraceevent: Increase libtraceevent logging when verbose")
> >
> > Hi,
> >
> > You forgot to add your Signed-off-by:, I'm adding it as you
> > usually provide it, ok?
>
> Also adding:
>
> Reported-by: Jiri Slaby <jirislaby@xxxxxxxxxx>
>
> - Arnaldo
Thanks Arnaldo! Both good with me.
Ian
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]