Re: [PATCH V8 03/14] rtla: Add osnoise tool
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH V8 03/14] rtla: Add osnoise tool
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Wed, 8 Dec 2021 17:14:06 -0500
- Cc: Tao Zhou <tao.zhou@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Tom Zanussi <zanussi@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, John Kacur <jkacur@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, linux-rt-users@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <9944378d-456f-79a5-2dbf-30dbbbc94522@kernel.org>
- References: <cover.1638182284.git.bristot@kernel.org> <ffb7f1b1e8cc42fc8ec52f1a89fdd2ca0d70c36e.1638182284.git.bristot@kernel.org> <YaZEzvzp5jkRyLEJ@geo.homenetwork> <9944378d-456f-79a5-2dbf-30dbbbc94522@kernel.org>
On Thu, 2 Dec 2021 16:18:53 +0100
Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:
> >> + if (!strcmp(context->orig_cpus, context->curr_cpus))
> >> + goto out_done;
> >> +
> >> + retval = write(context->cpus_fd, context->orig_cpus, strlen(context->orig_cpus));
> >
> > 'strlen(context->orig_cpus) + 1' for write size;
> >
> >> + if (retval < strlen(context->orig_cpus))
> >
> > Same here. Check 'strlen(context->orig_cpus) + 1'
>
> Fixed in v9.
And if you used the tracefs_instance_file_write() function, you would not
have had his bug ;-)
-- Steve
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]