Re: [PATCH V8 02/14] rtla: Helper functions for rtla
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH V8 02/14] rtla: Helper functions for rtla
- From: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
- Date: Fri, 3 Dec 2021 15:52:55 +0100
- Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Tom Zanussi <zanussi@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, John Kacur <jkacur@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, linux-rt-users@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <YaneZTnR+leNRzNN@geo.homenetwork>
- References: <cover.1638182284.git.bristot@kernel.org> <8fbb0e5ab5b39ba3c981fc97a3f93471d291cffc.1638182284.git.bristot@kernel.org> <YaneZTnR+leNRzNN@geo.homenetwork>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0
On 12/3/21 10:07, Tao Zhou wrote:
> On Mon, Nov 29, 2021 at 12:07:40PM +0100,
> Daniel Bristot de Oliveira wrote:
>
>> +/*
>> + * enable_tracer_by_name - enable a tracer on the given instance
>> + */
>> +int enable_tracer_by_name(struct tracefs_instance *inst, const char *tracer)
>> +{
>> + enum tracefs_tracers t;
>> + int retval;
>> +
>> + t = TRACEFS_TRACER_CUSTOM;
>> +
>> + debug_msg("enabling %s tracer\n", tracer);
>> +
>> + retval = tracefs_tracer_set(inst, t, tracer);
> The comment of parameters used for tracefs_tracer_set() says:
>
> '
> * tracefs_set_tracer - function to set the tracer
> * @instance: ftrace instance, can be NULL for top tracing instance
> * @tracer: The tracer enum that defines the tracer to be set
> * @t: A tracer name if TRACEFS_TRACER_CUSTOM is passed in for @tracer
> '
>
> tracefs_tracer_set(inst, tracer, t); @tracer is enum and @t is tracer
> name. this is not important.
>
cosmetics.
Anyway: s/tracer/tracer_name/ ; s/t/tracer/
-- Daniel
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]