Re: [PATCH v2] libtraceevent: Add __rel_loc relative location attribute support
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2] libtraceevent: Add __rel_loc relative location attribute support
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Mon, 29 Nov 2021 15:27:04 -0500
- Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>, linux-trace-devel@xxxxxxxxxxxxxxx, Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx>
- In-reply-to: <20211129201507.GA30603@kbox>
- References: <20211122223909.15f6fb50@rorschach.local.home> <163767457857.543504.6091850281066240970.stgit@devnote2> <20211129201507.GA30603@kbox>
On Mon, 29 Nov 2021 12:15:07 -0800
Beau Belgrave <beaub@xxxxxxxxxxxxxxxxxxx> wrote:
> > @@ -3308,19 +3318,23 @@ process_function(struct tep_event *event, struct tep_print_arg *arg,
> > free_token(token);
> > return process_int_array(event, arg, tok);
> > }
> > - if (strcmp(token, "__get_str") == 0) {
> > + if (strcmp(token, "__get_str") == 0 ||
> > + strcmp(token, "__get_rel_str") == 0) {
>
> Should user_events use __get_rel_str vs __get_str for the print_fmt?
> Both __dyn_loc and __rel_loc use __get_str currently.
I'm guessing that it should use the get_rel_str(), as get_str() will use
the absolute offset and not the relative one.
-- Steve
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]