Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode
- From: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
- Date: Thu, 25 Nov 2021 15:30:19 +0100
- Cc: Tao Zhou <tao.zhou@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Tom Zanussi <zanussi@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, John Kacur <jkacur@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, linux-rt-users@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <20211125092018.17e36369@oasis.local.home>
- References: <cover.1635535309.git.bristot@kernel.org> <1d9826696a1e8c3584158c0dd570b8b22db708db.1635535309.git.bristot@kernel.org> <20211124171212.537b43c3@gandalf.local.home> <20211124171503.584c8dd2@gandalf.local.home> <f815794d-bfb6-3e76-3572-3c1cc059c492@kernel.org> <20211125092018.17e36369@oasis.local.home>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0
On 11/25/21 15:20, Steven Rostedt wrote:
> On Thu, 25 Nov 2021 14:45:30 +0100
> Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:
>
>>> Or do you think that 1d should be the default, and we have:
>>>
>>> tracefs_hist_alloc() -- 1d histogram
>>> tracefs_hist_alloc_2d() -- 2d histogram
>>> tracefs_hist_alloc_nd() -- Nd histogram?
>>>
>>> ??
>>
>> IMHO, the function names in your second email sound more intuitive, i.e.,
>> tracefs_hist_alloc()/tracefs_hist_alloc_2d()/tracefs_hist_alloc_nd().
>>
>>> We haven't tagged it yet, so we could change it again (and then your code
>>> will work as is).
>>
>> two birds with a single stone :-)
>
> Just to confirm (confused by "second email" above), you prefer that we
> update the API to:
>
> tracefs_hist_alloc()
> tracefs_hist_alloc_2d()
> tracefs_hist_alloc_nd()
>
> Right?
Right!
-- Daniel
> Thanks,
>
> -- Steve
>
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]