On Wed, 24 Nov 2021 13:11:28 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Thu, 11 Nov 2021 17:08:40 +0200 > "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote: > > > > > static void add_reset_file(const char *file, const char *val, int prio) > > @@ -5974,6 +5975,7 @@ static void init_common_record_context(struct common_record_context *ctx, > > ctx->instance = &top_instance; > > ctx->curr_cmd = curr_cmd; > > local_cpu_count = tracecmd_count_cpus(); > > + ctx->file_version = FILE_VERSION_DEFAULT; > > This should not be exposed to the users of the API. > What you could do if you had to, is make a helper function for this: tracecmd_default_file_version(); That will return the default file version for the library. Which also means that the FILE_VERSION_DEFAULT macros should stay in trace-cmd-local.h and not be moved to the private header. -- Steve
|