On Thu, 11 Nov 2021 17:08:04 +0200 "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote: > --- a/lib/trace-cmd/trace-output.c > +++ b/lib/trace-cmd/trace-output.c > @@ -1395,6 +1395,20 @@ int tracecmd_write_buffer_info(struct tracecmd_output *handle) > return 0; > } > > +static tsize_t get_buffer_file_offset(struct tracecmd_output *handle, const char *name) > +{ > > +static int update_buffer_cpu_offset(struct tracecmd_output *handle, > + const char *name, tsize_t offset) > +{ Let's not have patches that add static functions that are not used. They should be added when they are used. I may just merge the patches. -- Steve