Re: [PATCH] libtraceevent: Add __rel_loc relative location attribute support

[Masami Hiramatsu <mhiramat@xxxxxxxxxx>]

On Mon, 22 Nov 2021 22:39:09 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Mon, 22 Nov 2021 18:36:57 +0900
> Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> 
> > @@ -3886,6 +3900,8 @@ static inline void dynamic_offset_field(struct tep_handle *tep,
> >  					unsigned int *len)
> >  {
> >  	dynamic_offset(tep, field->size, data + field->offset, offset, len);
> > +	if (field->flags & TEP_FIELD_IS_RELATIVE)
> > +		offset += field->offset + field->size;
> 
> I think you want *offset += field->offset + field->size;

Oops, good catch! Yes, that's right.

BTW, are there any tool I can use for testing this library?

Thank you,

> 
> -- Steve
> 
> >  }
> >  


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>