On Fri, 24 Sep 2021 19:56:41 +0300 Yordan Karadzhov <y.karadz@xxxxxxxxx> wrote: > > The new name of the function, mentioned in the patch description, is > > tracefs_hist_set_sort_key() > > I like the name with "set" instead of "reset". The behaviour of the > > function should be described in the function comments - to stress that > > the old keys are overwritten. > > > > Steven suggested to name it 'reset' in the review of the first version. > Both 'set' and 'reset' are OK for me. Looking at this now, I think "set" is a better name. I'll modify it. -- Steve
|