Re: [PATCH v5 01/12] libtracefs: New APIs for dynamic events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 5 Nov 2021 11:08:39 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> We can not rely on enums being signed or unsigned, so the above needs to be:
> 
> 	if ((unsigned int)type >= TRACEFS_DYNEVENT_MAX)
> 
> > +		return NULL;  
> 
> 
> And we should also not undefined types (more than one type masked in), so

   "we should also not allow undefined types"

-- Steve

> we really need an unsigned int:




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux