On Thu, 4 Nov 2021 14:47:34 +0200 Yordan Karadzhov <y.karadz@xxxxxxxxx> wrote: > > @@ -1919,7 +1911,6 @@ tracefs_synth_get_start_hist(struct tracefs_synth *synth) > > int tracefs_synth_create(struct tracefs_instance *instance, > > I wonder is it really necessary this function to take 'tracefs_instance' as argument? > > I remember from conversations with Steven that setting the histograms/triggers in the top instance will have the same > effect. Or maybe I am wrong? The same question applies for the 'destroy' API. Good point. Yeah, let's make the events global, and just use the top level for creation and destruction. As events added to the system affect all instances, they should only be done at the top level. -- Steve
|