On Wed, 3 Nov 2021 17:44:08 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
> +
> +struct dyn_events_desc {
> + enum tracefs_dynevent_type type;
> + const char *file;
> + const char *prefix;
> + int (*dyn_events_del)(struct dyn_events_desc *desc, struct tracefs_dynevent *dyn);
> + int (*dyn_events_parse)(struct dyn_events_desc *desc, const char *group,
> + char *line, struct tracefs_dynevent **ret_dyn);
BTW, there's no reason to have such a long field name for the function
pointer. Why not call it:
int (*del)(...);
int (*parse)(...);
?
It will make using it much easier and more readable.
-- Steve
> +} dynevents[] = {
> + {TRACEFS_DYNEVENT_KPROBE, NULL, "p", dyn_generic_del, dyn_generic_parse},
> + {TRACEFS_DYNEVENT_KRETPROBE, NULL, "r", dyn_generic_del, dyn_generic_parse},
> + {TRACEFS_DYNEVENT_UPROBE, NULL, "p", dyn_generic_del, dyn_generic_parse},
> + {TRACEFS_DYNEVENT_URETPROBE, NULL, "r", dyn_generic_del, dyn_generic_parse},
> + {TRACEFS_DYNEVENT_EPROBE, NULL, "e", dyn_generic_del, dyn_generic_parse},
> + {TRACEFS_DYNEVENT_SYNTH, NULL, "s", dyn_synth_del, dyn_synth_parse},
> +};
> +
|