On Tue, 2 Nov 2021 06:33:36 +0200 Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> wrote: > > > + > > > +#define DYNEVENTS_EVENTS "dynamic_events" > > > +#define KPROBE_EVENTS "kprobe_events" > > > > A definition of KPROBE_EVENTS already exists in /utest/tracefs-utest.c and src/tracefs-kprobes.c > > > > Isn't better to move the whole group of definitions of filenames to include/tracefs-local.h? > > The unit test should use only the official library API, defined in > tracefs.h. We could move these defines in the official API header, but > I think these should be internal to the library. Agreed. In fact, if one day the name changes (which is highly unlikely) we want the unit tests to fail on that ;-) -- Steve
|