Re: [PATCH V7 8/9] trace/osnoise: Remove STACKTRACE ifdefs from inside functions
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH V7 8/9] trace/osnoise: Remove STACKTRACE ifdefs from inside functions
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Fri, 29 Oct 2021 09:01:44 -0400
- Cc: Ingo Molnar <mingo@xxxxxxxxxx>, Tom Zanussi <zanussi@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, John Kacur <jkacur@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, linux-rt-users@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <b2c51cb7-1561-a23b-bba2-d8a8c5d27691@kernel.org>
- References: <cover.1635452903.git.bristot@kernel.org> <2cab388e4faaf3fc3496a1c18ec09a8bc7c36c3f.1635452903.git.bristot@kernel.org> <b2c51cb7-1561-a23b-bba2-d8a8c5d27691@kernel.org>
On Fri, 29 Oct 2021 14:31:27 +0200
Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:
> > + /*
> > + * 0 is disabled, so it will never be > than latency.
> > + */
> > + if (osnoise_data.print_stack > latency)
> > + return;
>
> Oops, I placed the comment, but forgot to place the check. This if should be:
>
> if (!osnoise_data.print_stack || osnoise_data.print_stack > latency)
> return;
Or I could've had a V8!
https://www.youtube.com/watch?v=qYo0lVVH2wU
-- Steve
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]