On Thu, 28 Oct 2021 15:08:58 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
> +static struct tracefs_dynevent *
> +kprobe_alloc(enum trace_dynevent_type type, const char *system, const char *event,
> + const char *addr, const char *format)
> +{
> + struct tracefs_dynevent *kp;
> + const char *sys = system;
> + const char *ename = event;
> + char *tmp;
> +
> + if (!addr || !format) {
> + errno = EBADMSG;
> + return NULL;
> + }
> + if (!sys)
> + sys = KPROBE_DEFAULT_GROUP;
> +
> + if (!event) {
> + ename = strdup(addr);
> + if (!ename)
> + return NULL;
> + tmp = strchr(ename, ':');
> + if (tmp)
> + *tmp = '\0';
> + }
> +
> + kp = dynevent_alloc(type, sys, ename, addr, format);
> + if (!event)
> + free((char *)ename);
> + if (!kp)
> + return NULL;
> + return kp;
If !kp is true, then return kp is the same as return NULL;
Nuke the "if (!kp)" code.
> +}
> +
> +
-- Steve
|