Re: [PATCH V5 10/20] rtla/osnoise: Add osnoise top mode
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH V5 10/20] rtla/osnoise: Add osnoise top mode
- From: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
- Date: Tue, 26 Oct 2021 21:50:57 +0200
- Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Tom Zanussi <zanussi@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, John Kacur <jkacur@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, linux-rt-users@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <YXgtnEPcT8vay1wI@geo.homenetwork>
- References: <cover.1635181938.git.bristot@kernel.org> <6252864d71e1864f60c25c716bc773861929e3fb.1635181938.git.bristot@kernel.org> <YXgtnEPcT8vay1wI@geo.homenetwork>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0
On 10/26/21 18:32, Tao Zhou wrote:
>> + if (params->stop_us)
>> + osnoise_set_stop_us(tool->context, params->stop_us);
> osnoise_set_stop_us() also need to check return value feels by me.
>
>> +
>> + if (params->stop_total_us)
>> + osnoise_set_stop_total_us(tool->context, params->stop_total_us);
> The same here. Also need to check the return value.
>
> PATCH 10 also has these two places(call the two functions) that not check
> the return value.
>
> Or I am wrong.
You are right, reviewing that.
Thanks!
-- Daniel
>
>
> Thanks,
> Tao
>
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]