Re: [PATCH V5 08/20] rtla: Helper functions for rtla
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH V5 08/20] rtla: Helper functions for rtla
- From: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
- Date: Tue, 26 Oct 2021 21:45:43 +0200
- Cc: Ingo Molnar <mingo@xxxxxxxxxx>, Tom Zanussi <zanussi@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, John Kacur <jkacur@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, linux-rt-users@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <20211026122614.017844da@gandalf.local.home>
- References: <cover.1635181938.git.bristot@kernel.org> <bc01018cef80ddb95fd0ccf1ec72963be7e4fc19.1635181938.git.bristot@kernel.org> <YXgrLIiK8pwOVsBe@geo.homenetwork> <20211026122614.017844da@gandalf.local.home>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0
On 10/26/21 18:26, Steven Rostedt wrote:
> On Wed, 27 Oct 2021 00:22:04 +0800
> Tao Zhou <tao.zhou@xxxxxxxxx> wrote:
>
>>> + do {
>>> + retval = read(in_fd, buffer, sizeof(buffer));
>>> + if (read <= 0)
>> check "retval" not read. Like:
>>
>> if (retval <= 0)
> OUCH! Good check.
>
> Daniel, did that not produce any warnings??
OUCH OUCH!
No warnings, no nothing.
The code actually "works" because errors are not common and the next if stops
the loop.
-- Daniel
> -- Steve
>
>
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]