Re: [PATCH V4 04/19] trace/osnoise: Support a list of trace_array *tr
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH V4 04/19] trace/osnoise: Support a list of trace_array *tr
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Mon, 25 Oct 2021 09:35:41 -0400
- Cc: paulmck@xxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, Tom Zanussi <zanussi@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, John Kacur <jkacur@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, linux-rt-users@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <5f1ae99f-a7b2-e25f-800c-4e6e87b936ca@kernel.org>
- References: <cover.1634820694.git.bristot@kernel.org> <d54f5bfa2b2fbd11393c2a69a8b5cbdd808a506d.1634820694.git.bristot@kernel.org> <20211022223839.476905ed@rorschach.local.home> <20211025032614.GN880162@paulmck-ThinkPad-P17-Gen-1> <5f1ae99f-a7b2-e25f-800c-4e6e87b936ca@kernel.org>
On Mon, 25 Oct 2021 11:10:26 +0200
Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:
> The start/stop/reset operations are called from trace "core" operations. So they
> are all protected/serialized by trace_types_lock (by trace/core).
>
> So, it seems that the way to go is to remove the rcu_read_lock/unlock() from
> unregister, adding a lockdep check to see if trace_types_lock is help as a bonus?
Yes, I would recommend the lockdep assert added. This way it also documents
what lock protects modification of the list.
Thanks,
-- Steve
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]