Hi Beau,
On Thu, 30 Sep 2021 15:38:21 -0700
Beau Belgrave <beaub@xxxxxxxxxxxxxxxxxxx> wrote:
> synth_events is returning -EINVAL if the dyn_event create command does
> not contain ' \t'. This prevents other systems from getting called back.
> synth_events needs to return -ECANCELED in these cases when the command
> is not targeting the synth_event system.
Thanks for clean up the synthetic event!
This looks good to me.
Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
So now are you trying to reuse synth event for user event?
Then I think you need to register a new dyn_event ops so
that histogram will not submit the event.
BTW, how do you filter an event written by a user process?
Will you add an array of event id for the file data structure?
Thank you,
>
> Signed-off-by: Beau Belgrave <beaub@xxxxxxxxxxxxxxxxxxx>
> ---
> kernel/trace/trace_events_synth.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
> index 9315fc03e303..08b7ea639cea 100644
> --- a/kernel/trace/trace_events_synth.c
> +++ b/kernel/trace/trace_events_synth.c
> @@ -2051,6 +2051,13 @@ static int create_synth_event(const char *raw_command)
>
> last_cmd_set(raw_command);
>
> + name = raw_command;
> +
> + /* Don't try to process if not our system */
> + if (name[0] != 's' || name[1] != ':')
> + return -ECANCELED;
> + name += 2;
> +
> p = strpbrk(raw_command, " \t");
> if (!p) {
> synth_err(SYNTH_ERR_INVALID_CMD, 0);
> @@ -2059,12 +2066,6 @@ static int create_synth_event(const char *raw_command)
>
> fields = skip_spaces(p);
>
> - name = raw_command;
> -
> - if (name[0] != 's' || name[1] != ':')
> - return -ECANCELED;
> - name += 2;
> -
> /* This interface accepts group name prefix */
> if (strchr(name, '/')) {
> len = str_has_prefix(name, SYNTH_SYSTEM "/");
> --
> 2.17.1
>
--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>
|