On 24.09.21 г. 18:54, Steven Rostedt wrote:
On Fri, 24 Sep 2021 18:51:38 +0300 Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> wrote:struct tracefs_hist * tracefs_hist_alloc(struct tep_handle *tep,For consistency with the newly added "alloc" APIs, this should be renamed. The dimensions of the histogram are part of the name, this one is for N dimensions: tracefs_hist_alloc_1d() tracefs_hist_alloc_2d() tracefs_hist_alloc_nd() or something like that.I rather not have the _nd(). tracefs_hist_alloc_1d() tracefs_hist_alloc_2d() are more just helper handlers for specific cases. tracefs_hist_alloc() should be the "main" function, and hence doesn't need any extra annotation.
My idea was the same. Thanks! Yordan
-- Steve
|