On Mon, 13 Sep 2021 15:26:51 +0300 Yordan Karadzhov <y.karadz@xxxxxxxxx> wrote: > > How about if we call this: > > > > tracefs_hist_replace_sort_keys() > > > > I think that would be a more intuitive name. > > The user may call this function with a histogram that has no sort keys added. > So there will be nothing to replace. > What about naming it 'tracefs_hist_set_sort_keys()'? Nothing is something to replace? Or we remove this completely, and have a: tracefs_hist_reset_sort_keys() Which removes all sort keys, and let you to start with a clean plate. Thus, the above would really just be "reset" followed by "add". -- Steve
|