On 10.09.21 г. 23:04, Steven Rostedt wrote:
On Fri, 10 Sep 2021 19:38:55 +0300 "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:The current version of the API makes it hard to add multiple sort keys to a histogram. The only way to do this is to use the variadic arguments, however in order to do this the caller have to know the number of sort keys at compile time, because the method overwrite all previously added keys. The problem is addressed by splitting tracefs_hist_add_sort_key() into two methods - one that overwrite and one that does not.If I'm building a histogram via some interactive method, and have created a histogram instance. How do I add a new key before executing it?
Is this comment about adding 'key' or about adding 'sort key'? Thanks! Yordan
-- Steve
|