On Thu, 29 Jul 2021 08:09:22 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
> @@ -3752,11 +3755,38 @@ struct tracecmd_input *tracecmd_alloc_fd(int fd, int flags)
> handle->total_file_size = lseek64(handle->fd, 0, SEEK_END);
> lseek64(handle->fd, offset, SEEK_SET);
>
> + if (handle->file_version >= 7) {
In the next version, remove all comparisons to 7, and create feature
flags. Then in one place, where the version is decided on, it will set
the feature flags that are supported by that version. And everyplace
else, references the features, not the number. Because 7 is really
meaningless, and years from now, will just cause more confusion.
-- Steve
> + zname = read_string(handle);
> + if (!zname)
> + goto failed_read;
> + zver = read_string(handle);
> + if (!zver)
> + goto failed_read;
> + if (strcmp(zname, "none")) {
|