Re: [PATCH v2 1/2] libtraceevent: Add dynamic_offset()

[Steven Rostedt <rostedt@xxxxxxxxxxx>]

On Wed,  4 Aug 2021 15:55:25 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:

> +	if (*offset)
> +		*offset = (unsigned int)(val & TEP_OFFSET_LEN_MASK);
> +	if (*len)
> +		*len = (unsigned int)((val >> TEP_LEN_SHIFT) & TEP_OFFSET_LEN_MASK);
> +}

Oops, the above is wrong. It should be:

	if (offset)
		*offset = (unsigned int)(val & TEP_OFFSET_LEN_MASK);
	if (len)
		*len = (unsigned int)((val >> TEP_LEN_SHIFT) & TEP_OFFSET_LEN_MASK);

And yes, this would crash if NULL is passed in.

-- Steve