[PATCH 2/2] libtracefs: Silence sometimes-uninitialized warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Warning generated by clang:

src/tracefs-events.c:1046:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
        if (!systems)
            ^~~~~~~~
src/tracefs-events.c:1101:9: note: uninitialized use occurs here
        return ret;
               ^~~
src/tracefs-events.c:1046:2: note: remove the 'if' if its condition is always false
        if (!systems)
        ^~~~~~~~~~~~~
src/tracefs-events.c:1038:9: note: initialize the variable 'ret' to silence this warning
        int ret;
               ^
                = 0

Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
---
 src/tracefs-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tracefs-events.c b/src/tracefs-events.c
index 8d84838..4679926 100644
--- a/src/tracefs-events.c
+++ b/src/tracefs-events.c
@@ -1035,7 +1035,7 @@ static int event_enable_disable(struct tracefs_instance *instance,
 	regex_t system_re, event_re;
 	char **systems;
 	char **events = NULL;
-	int ret;
+	int ret = -1;
 	int s, e;
 
 	/* Handle all events first */
-- 
2.32.0.554.ge1b32706d8-goog




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux