From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
When writing the sqlhist interface, I found that calling ">" GT and "!="
NE were more sensible than calling them GR and NQ, as we already have LT
as "less than" why not use GT as "greater than". As well as EQ for
"equal", it seems more appropriate to have NE be "not equal".
Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
---
Documentation/libtracefs-synth.txt | 4 ++--
include/tracefs.h | 4 ++--
src/tracefs-hist.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/libtracefs-synth.txt b/Documentation/libtracefs-synth.txt
index 0e74e4f3aa0b..b20b4a7eb911 100644
--- a/Documentation/libtracefs-synth.txt
+++ b/Documentation/libtracefs-synth.txt
@@ -137,9 +137,9 @@ may be one of:
*TRACEFS_COMPARE_EQ* - _field_ == _val_
-*TRACEFS_COMPARE_NQ* - _field_ != _val_
+*TRACEFS_COMPARE_NE* - _field_ != _val_
-*TRACEFS_COMPARE_GR* - _field_ > _val_
+*TRACEFS_COMPARE_GT* - _field_ > _val_
*TRACEFS_COMPARE_GE* - _field_ >= _val_
diff --git a/include/tracefs.h b/include/tracefs.h
index 9cfd2577da2e..03a16bbffdc7 100644
--- a/include/tracefs.h
+++ b/include/tracefs.h
@@ -315,8 +315,8 @@ enum tracefs_synth_calc {
enum tracefs_synth_compare {
TRACEFS_COMPARE_EQ,
- TRACEFS_COMPARE_NQ,
- TRACEFS_COMPARE_GR,
+ TRACEFS_COMPARE_NE,
+ TRACEFS_COMPARE_GT,
TRACEFS_COMPARE_GE,
TRACEFS_COMPARE_LT,
TRACEFS_COMPARE_LE,
diff --git a/src/tracefs-hist.c b/src/tracefs-hist.c
index 8b9078791ab2..11355e648692 100644
--- a/src/tracefs-hist.c
+++ b/src/tracefs-hist.c
@@ -1178,11 +1178,11 @@ static int add_synth_filter(char **filter, const char *field,
op = "==";
break;
- case TRACEFS_COMPARE_NQ:
+ case TRACEFS_COMPARE_NE:
op = "!=";
break;
- case TRACEFS_COMPARE_GR:
+ case TRACEFS_COMPARE_GT:
op = ">";
if (is_string)
goto inval;
--
2.30.2
|