Re: [PATCH] libtraceevent: Fix bug in tep_print_event()

["Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx>]

On 30.06.21 г. 18:06, Steven Rostedt wrote:
> On Wed, 30 Jun 2021 17:19:13 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:
>
> > {
> >   	struct print_event_type type;
> > -	char *format = strdup(fmt);
> > -	char *current = format;
> > -	char *str = format;
> > +	char *format, *current, *str;
>
> Nit, but please keep the above each on a separate line.
>
> 	char *current;
> 	char *format;
> 	char *str;
>
> I try to avoid having pointers on a single line, it's just easier to
> manage when they are separate.

I am sorry!
I somehow forgot that we already discussed this before.
Should I send v2?

Thanks,
Y.

> Thanks!
>
> -- Steve
>
> >   	int offset;
> >   	va_list args;
> >   	struct tep_event *event;
> >   
> > +	event = tep_find_event_by_record(tep, record);
> > +	if (!event) {
> > +		trace_seq_printf(s, "[UNKNOWN EVENT]");
> > +		return;
> > +	}
> > +
> > +	str = current = format = strdup(fmt);
> >   	if (!format)
> >   		return;