Re: [PATCH] trace-cmd split: Copy trace_clock from input handler to output handler
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] trace-cmd split: Copy trace_clock from input handler to output handler
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Tue, 22 Jun 2021 17:38:43 -0400
- Cc: Linux Trace Devel <linux-trace-devel@xxxxxxxxxxxxxxx>
- In-reply-to: <alpine.DEB.2.22.394.2106222322590.80759@hadrien>
- References: <20210622171338.6447f199@gandalf.local.home> <alpine.DEB.2.22.394.2106222322590.80759@hadrien>
On Tue, 22 Jun 2021 23:25:23 +0200 (CEST)
Julia Lawall <julia.lawall@xxxxxxxx> wrote:
> > Add a new function to retrieve the trace_clock from the input handle, to
> > be used to pass it to the output handle before appending the CPU data.
>
> Just to confirm, is it still possible to run trace-cmd split without being
> root?
Yes, it was a bug that you couldn't read it as non-root. And it shouldn't be
reading the local trace_clock anyway, even if you are root.
1) because it could be splitting a trace.dat file from another machine
(which is what I was doing)
2) the trace_clock of the machine could have changed since the trace was
run.
-- Steve
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]