On Tue, Jun 22, 2021 at 2:10 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Mon, 14 Jun 2021 10:50:05 +0300 > "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote: > > > Comperss the option section of the trace file. This section is not big > > currently and compressing it does not reduce significantly the size of > > the file. This could be useful in the future as new options can be > > added, storing a potentially huge amount of data. > > I'm not sure we want to bother doing this. New options should never be > large, and if they are, then the option itself can be compressed when > created. > > What good reason is there to compress the options? I think adding any new metadata should be done only by adding new options - this will not break the format. For example kernel debug information for parsing function's arguments - it will be huge. Having the entire option section compressed will simplify that. And it is consistent with the other metadata sections. > > I believe this is just adding more complexity than needed. > > -- Steve -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|