On Sun, Jun 13, 2021 at 4:29 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Sun, 13 Jun 2021 14:31:42 -0700
> Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
>
> > Would it be more conventional in this situation to use quotes within
> > the library and angles outside? This change is within the library and
> > not with code trying to link against it.
>
> Does it matter? If not, what's the purpose of changing it?
Sorry for not having this in the body, in the cover message I added to
Claire's email with:
> Some build systems are picky about angled vs quotes, fix this minor issue.
The problem is with certain build system, we use bazel at Google,
where iquote is used for includes within the library, and other
flavors outside the library. There's a similar conversation here:
https://groups.google.com/g/bazel-discuss/c/6MNuZ5bKoa8?pli=1
the failure you see when building is:
In file included from src/event-parse.c:27:
src/event-utils.h:13:10: error: 'event-parse.h' file not found with
<angled> include; use "quotes" instead
#include <event-parse.h>
^~~~~~~~~~~~~~~
"event-parse.h"
Arguably -iquote is more correct within the library build, hence bazel
using it. The libtraceevent Makefile is using -I, hence this not being
a problem for others. We prefer not to carry internal patches, hence
wanting to send this upstream.
Thanks,
Ian
> Note, the change log is empty, and is where rationale for the change is
> suppose to be added.
>
> -- Steve
|