On Tue, 18 May 2021 20:48:35 +0530 sameeruddin shaik <sameeross1994@xxxxxxxxx> wrote: > > BTW, when a reviewer of your code gives a code example of a better > > implementation, you should express that in your change log. I usually use: > > > > Suggested-by: ... > > > > So you should have: > > > > Suggested-by: Steven Rostedt <rostedt@xxxxxxxxxxx> > > > > as the above is pretty much exact copy of the code snippet I posted. > okay steve, > since i don't know, about this suggested-by, i haven't included. otherwise > i could have done. No problem. I'm just educating you ;-) -- Steve
|