Re: [PATCH 0/7] Final fixes before KS 2.0

Yordan Karadzhov <y.karadz@xxxxxxxxx> · Mon, 17 May 2021 16:04:19 +0300

On 17.05.21 г. 15:54, Steven Rostedt wrote:

On Mon, 17 May 2021 13:22:34 +0300
Yordan Karadzhov <y.karadz@xxxxxxxxx> wrote:

On 14.05.21 г. 21:01, Steven Rostedt wrote:

On Fri, 14 May 2021 15:18:19 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:

Yordan Karadzhov (VMware) (7):
    kernel-shark: Preserve markers when appending data
    kernel-shark: Preserve open graphs when appending data
    kernel-shark: Clear before loading new session
    kernel-shark: Better handling of plugins when appending data file
    kernel-shark: Do draw the combo point of the mark
    kernel-shark: Check if "trace_seq" was destroyed before using it
    kernel-shark: Quiet the warning printing from libtraceevent

After applying and testing out this patch set, I realized that the appended
file does not have any of its CPUs plotted after it is loaded.

Yes, this is how it works right now. No new plots are added when you
append trace file.

Do you think it will be to show all CPU plots from the new trace file?

Yeah, I think it is better to see something than nothing.

OK, I will send v2 that is doing this. It will be a trivial change.

I don't think there's an issue with showing it. Although, if you could
automate the kvm combo to be selected by default on appending a file, then
you wouldn't need to show the cpu plots of the guest.

This can be done as well but it may be a bit tricky. We should probably 

also provide a command line option for selecting combo plots.

But let's release v2.0 now and keep this feature for v2.1, together with 

the other features you requested on Bugzilla.

Thanks!
Yordan

-- Steve