On Fri, May 14, 2021 at 12:23 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Fri, 7 May 2021 12:53:28 +0300 > "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote: > > > Removed the "weak" definition of the library log functions. Setting > > the desired log level can be used to silence the library logs, instead > > of overwriting the log functions. > > That's not the purpose of the weak definition. It is so that a GUI (like > kernelshark) can turn it into a pop up if need be or show in a status > window. It was not for quieting the function. The description is not correct. All these log functions use tep_vprint(), which is implemented as weak. This function has information for the library and log severity and should be used by kernelshark for that purpose. That's why I removed weak library specific functions. > > Please do not remove the weak symbols. > > -- Steve -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|