On Fri, 7 May 2021 12:50:21 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
> diff --git a/src/event-utils.h b/src/event-utils.h
> index 1951557..0617a28 100644
> --- a/src/event-utils.h
> +++ b/src/event-utils.h
> @@ -9,10 +9,11 @@
> #include <ctype.h>
> #include <stdarg.h>
>
> +void tep_warning(const char *fmt, ...);
> void tep_info(const char *fmt, ...);
> /* Can be overridden */
> -void tep_warning(const char *fmt, ...);
> -int tep_vwarning(const char *name, const char *fmt, va_list ap);
> +int tep_vprint(const char *name, enum tep_loglevel level,
> + bool print_err, const char *fmt, va_list ap);
>
> #define min(x, y) ({ \
> typeof(x) _min1 = (x); \
I have the following build error on trace-cmd:
In file included from trace-util.c:23:
/usr/local/include/traceevent/event-utils.h:16:9: error: unknown type name ‘bool’
16 | bool print_err, const char *fmt, va_list ap);
| ^~~~
Needs to include <stdbool.h> in event-utils.h, can not rely that this
would exist in the use cases.
I'll add it to this patch, unless I find other issues for a v3.
-- Steve
|