On Tue, 4 May 2021 16:00:08 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > Renamed existing pr_stat() internal function to tep_info() and limit it
>
> Unfortunately they are also not internal functions :-(
>
> > to print only when the log level is TEP_LOG_INFO. Removed duplicated and
> > unused functions:
> > vpr_stat()
> > __pr_stat()
> > __vpr_stat()
>
> trace-record.c: In function ‘expand_event_files’:
> trace-record.c:2971:3: warning: implicit declaration of function ‘pr_stat’; did you mean ‘lstat’? [-Wimplicit-function-declaration]
> 2971 | pr_stat("%s\n", path);
> | ^~~~~~~
> | lstat
>
>
> ctracecmd_wrap.c: In function ‘pr_stat’:
> ctracecmd_wrap.c:2779:2: warning: implicit declaration of function ‘__vpr_stat’; did you mean ‘pr_stat’? [-Wimplicit-function-declaration]
> 2779 | __vpr_stat(fmt, ap);
> | ^~~~~~~~~~
> | pr_stat
So I added another patch to bring these back for backward compatibility.
Feel free to remove them in this series, and I'll just add that patch at
the end:
https://lore.kernel.org/linux-trace-devel/20210504163156.2bfdd63d@xxxxxxxxxxxxxxxxxx/
But as I still have issues with this patch series and will wait for your
reply before applying anything.
Thanks,
-- Steve
|