Re: [PATCH] trace-cmd list: Add --full to show print fmt of an event

[Steven Rostedt <rostedt@xxxxxxxxxxx>]

On Thu, 22 Apr 2021 22:41:54 +0200
Nicolas Sterchele <nicolas@xxxxxxxxxxxxxx> wrote:

> >@@ -84,7 +85,7 @@ static void process_file_re(process_file_func func,
> > 		strcpy(&str[l-1], "\n*$");
> >
> > 	if (regcomp(&reg, str, REG_ICASE|REG_NOSUB))
> >-		die("invalid function regex '%s'", re);
> >+		die("invalid function regex '%s'", re, flags);  
> 
> Shouldn't we add `flags` inside the fmt string?:
> 		die("invalid function regex '%s' with '%d' as flags", re, flags);

Nice catch, but no, flags just needs to be dropped.

The "flags" was added in a different patch, and as I was writing updates in
individual patches (and not a series), I found that in some places that I
had conflicts. And the patch that added "flags" all over the place I had to
update accordingly.

This is simply a case of me adding ", flags" to the wrong function
(*embarrassed*)!

It doesn't need to be printed, but it shouldn't be passed to die either.

One way I could have caught this was by adding the printf attribute to the
die() header, where things like this will cause warnings.

Thanks for the report. I'll fix it.

-- Steve


> 
> > 	free(str);