On Fri, 2 Apr 2021 10:17:56 -0400 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > Do you still feel that the moving of this code is needed? The rest of the patch series looks fine. Can you send a v2? I'll let you and Tzvetomir decide if you want the code from this patch moved to the instance file. But at a minimum, lets rename tracefs_option_set() to trace_option_set(). Thanks! -- Steve