On Fri, 2 Apr 2021 16:19:44 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:
> @@ -197,6 +201,13 @@ enum tracefs_option_id tracefs_option_id(const char *name)
> return TRACEFS_OPTION_INVALID;
> }
>
> +static void tracefs_option_set(struct tracefs_options_mask *options,
> + enum tracefs_option_id id)
Patch is fine, but lets rename this function to:
trace_option_set()
As functions named "tracefs_*()" should be used only by functions that are
for the API or will be for the API (staging functions).
-- Steve
> +{
> + if (options && id > TRACEFS_OPTION_INVALID)
> + options->mask |= (1ULL << (id - 1));
> +}
> +
> static struct tracefs_options_mask *trace_get_options(struct tracefs_instance *instance,
> bool enabled)
> {
|